HTML Accesskey doesn't work on MAC OS X

[khushboovashi]

Hi,

We have used your webkit in our project. I am facing the issue related to HTML access-keys.
On MAC OS X, the access keys don't work; I tried to dig into it and found out that the events are not getting generated. For, example if I have used access-keys f to open the file menu then while I press (Alt + F), it should generate the mouse event which is not happening.

Can you please help me to figure this out.

Thanks,
Khushboo

[annulen]

Did it work with older QtWebKit versions, e.g. one coming with Qt 5.5?

[khushboovashi]

MAC OS X - Doesn't work with official webkit 5.5 or newer version, not with Annulen 5.8 and also with webengine it doesn't work.
Linux - Works with everything
Windows: Works with Annulen 5.9 webkit

So, we have only issue on MAC OS X.

[annulen]

Is there any old report on this topic in bugreports.qt.io? I need to get as much details as possible, as I still don't realise what's all this about

[neel5481]

Issue was reported in 2009 as per below link but don't know it is integrated in Webkit source or not.
https://bugs.webkit.org/show_bug.cgi?id=32213

[annulen]

Does Ctrl-Alt-F work?

[khushboovashi]

No. We have tried different key variations but didn't work.

[annulen]

I've tried test case https://github.com/annulen/webkit/blob/qtwebkit-stable/LayoutTests/fast/forms/access-key.html on Linux, works fine here.

Please try Command+Alt combination

[khushboovashi]

The problem is on the MAC OS X. On Linux it is working as expected.

…

On 31 Jul 2017 17:08, "Konstantin Tokarev" ***@***.***> wrote: I've tried test case https://github.com/annulen/ webkit/blob/qtwebkit-stable/LayoutTests/fast/forms/access-key.html on Linux, works fine here. Please try Command+Alt combination — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#594 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANrlScH2TclCLo7Mmb0cr6bPMLo32zU7ks5sTby1gaJpZM4OhGeX> .

[annulen]

Doesn't Command+Alt work?

If you can rebuild from sources I can give you a patch to try

[khushboovashi]

On Mon, Jul 31, 2017 at 7:53 PM, Konstantin Tokarev < ***@***.***> wrote: Doesn't Command+Alt work?

No. It doesn't work on MAC.

If you can rebuild from sources I can give you a patch to try

Yes. we can do this. Can you please provide the steps/documentation link to do this ? I would like to clarify that, if this issue would be fixed with this patch, then you will commit this patch to the repository.

…

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#594 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANrlST-gHJqUnu-2I-JSu3apPhdHxiOJks5sTeNMgaJpZM4OhGeX> .

[annulen]

Can you please provide the steps/documentation link to do this ?

https://github.com/annulen/webkit/wiki/Building-QtWebKit-on-OS-X

I would like to clarify that, if this issue would be fixed with this patch, then you will commit this patch to the repository.

Sure

Here is the patch:

diff --git a/Source/WebCore/page/qt/EventHandlerQt.cpp b/Source/WebCore/page/qt/EventHandlerQt.cpp
index 240ea75eb74..334ebbf6a3a 100644
--- a/Source/WebCore/page/qt/EventHandlerQt.cpp
+++ b/Source/WebCore/page/qt/EventHandlerQt.cpp
@@ -123,7 +123,7 @@ bool EventHandler::passMouseReleaseEventToSubframe(MouseEventWithHitTestResults&
 unsigned EventHandler::accessKeyModifiers()
 {
 #if OS(DARWIN)
-    return PlatformEvent::CtrlKey | PlatformEvent::AltKey;
+    return PlatformEvent::AltKey;
 #else
     return PlatformEvent::AltKey;
 #endif

[annulen]

With patch Alt+F is expected to be working

[khushboovashi]

On Tue, Aug 1, 2017 at 2:43 PM, Konstantin Tokarev ***@***.*** > wrote: With patch Alt+F is expected to be working

Thanks. I am currently trying to build webkit. I will let you know the status once it's done.

…

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#594 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANrlSQf_G-fnoMjtQrYR4uC8JAcPx6Zpks5sTuxBgaJpZM4OhGeX> .

[khushboovashi]

Hi, The build was successful but when I run my application, I get below error. dyld: Library not loaded: /Users/username/Projects/qtwebkit/WebKitBuild/Release/lib/@rpath/QtWebKit.framework/Versions/5/QtWebKit Referenced from: /Users/username/Qt5.9.1/5.9.1/clang_64/lib/QtWebKitWidgets.framework/Versions/5/QtWebKitWidgets Reason: image not found Trace/BPT trap: 5 On Tue, Aug 1, 2017 at 2:45 PM, khushboo Vashi <khushboo.vashi@gmail.com> wrote:

…

On Tue, Aug 1, 2017 at 2:43 PM, Konstantin Tokarev < ***@***.***> wrote: > With patch Alt+F is expected to be working > Thanks. I am currently trying to build webkit. I will let you know the status once it's done. > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#594 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ANrlSQf_G-fnoMjtQrYR4uC8JAcPx6Zpks5sTuxBgaJpZM4OhGeX> > . >

[khushboovashi]

On Tue, Aug 1, 2017 at 3:55 PM, khushboo Vashi <khushboo.vashi@gmail.com> wrote:

Hi, The build was successful but when I run my application, I get below error. dyld: Library not loaded: /Users/username/Projects/ ***@***.***/QtWebKit.framework/ Versions/5/QtWebKit Referenced from: /Users/username/Qt5.9.1/5.9.1/ clang_64/lib/QtWebKitWidgets.framework/Versions/5/QtWebKitWidgets Reason: image not found Trace/BPT trap: 5

I have resolved the dyld error and tested your patch. Unfortunately the access-keys (ALT + key ) are still not working.

…

On Tue, Aug 1, 2017 at 2:45 PM, khushboo Vashi ***@***.***> wrote: > > > On Tue, Aug 1, 2017 at 2:43 PM, Konstantin Tokarev < > ***@***.***> wrote: > >> With patch Alt+F is expected to be working >> > Thanks. I am currently trying to build webkit. I will let you know the > status once it's done. > >> — >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> <#594 (comment)>, >> or mute the thread >> <https://github.com/notifications/unsubscribe-auth/ANrlSQf_G-fnoMjtQrYR4uC8JAcPx6Zpks5sTuxBgaJpZM4OhGeX> >> . >> > >

[sl1pkn07]

@khushboovashi how your resolve the rpath issue? with CMAKE_MACOSX_RPATH=OFF?

i have the same issue with (qt)webkit builded throught Brew

[annulen]

Fixed in abbe383 and b519900

[khushboovashi]

Thanks for working on this.