Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep qualified names #1392

Merged
merged 7 commits into from
Jul 21, 2022
Merged

Keep qualified names #1392

merged 7 commits into from
Jul 21, 2022

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Jul 18, 2022 •
edited
Loading

Fixes #1344

Adds a new field to Abstract Name called _namePretty :: Text.
This field contains the full textual representation of the name, including qualification.

@janmasrovira janmasrovira added enhancement New feature or request error-messaging labels Jul 18, 2022
@janmasrovira janmasrovira added this to the 0.2.2 milestone Jul 18, 2022
@janmasrovira janmasrovira self-assigned this Jul 18, 2022
@janmasrovira janmasrovira linked an issue Jul 18, 2022 that may be closed by this pull request
Debugging: Add qualification in error message. #1344
Closed
@janmasrovira janmasrovira changed the title keep qualified names Keep qualified names Jul 18, 2022
@janmasrovira janmasrovira force-pushed the 1344-debugging-add-qualification-in-error-message branch 2 times, most recently from 2a50cfb to baad77c Compare July 20, 2022 15:56
@janmasrovira janmasrovira marked this pull request as ready for review July 20, 2022 16:05
@jonaprieto jonaprieto self-requested a review July 21, 2022 08:11
@jonaprieto jonaprieto force-pushed the 1344-debugging-add-qualification-in-error-message branch from 014ecb9 to 99107b3 Compare July 21, 2022 10:39
jonaprieto
jonaprieto previously approved these changes Jul 21, 2022
View reviewed changes
@jonaprieto jonaprieto self-requested a review July 21, 2022 11:03
@jonaprieto jonaprieto force-pushed the 1344-debugging-add-qualification-in-error-message branch from 94ab2d1 to b274958 Compare July 21, 2022 13:23
@jonaprieto jonaprieto merged commit e939f8f into main Jul 21, 2022
@jonaprieto jonaprieto deleted the 1344-debugging-add-qualification-in-error-message branch July 21, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaprieto jonaprieto jonaprieto approved these changes

Assignees

@janmasrovira janmasrovira

Labels
enhancement New feature or request error-messaging
Projects
None yet
Milestone
0.2.2
Development

Successfully merging this pull request may close these issues.

Debugging: Add qualification in error message.
2 participants
@janmasrovira @jonaprieto