New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make lambda lifting correct when free variables occur in the types of binders #1609
Merged
janmasrovira
merged 18 commits into
main
from
1584-make-lambda-lifting-correct-when-free-variables-occur-in-the-types-of-binders
Nov 9, 2022
Merged
Make lambda lifting correct when free variables occur in the types of binders #1609
janmasrovira
merged 18 commits into
main
from
1584-make-lambda-lifting-correct-when-free-variables-occur-in-the-types-of-binders
Nov 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
force-pushed
the
1584-make-lambda-lifting-correct-when-free-variables-occur-in-the-types-of-binders
branch
from
November 8, 2022 08:29
388ed1d
to
ce599e1
Compare
lukaszcz
requested changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crashes, unfortunately. I added a test which should help in finding the bug.
lukaszcz
force-pushed
the
1584-make-lambda-lifting-correct-when-free-variables-occur-in-the-types-of-binders
branch
from
November 9, 2022 12:02
88c29a8
to
4f1cbb2
Compare
lukaszcz
approved these changes
Nov 9, 2022
janmasrovira
deleted the
1584-make-lambda-lifting-correct-when-free-variables-occur-in-the-types-of-binders
branch
November 9, 2022 12:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1584.
This pr includes: