Fix registration of builtin inductive axioms #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builtin inductive axioms must be registered in the same pass as inductive types becuase inductive types may use builtin inductives in the types of their constructors. ``` builtin string axiom String : Type; type BoxedString := | boxed : String -> BoxedString; ``` The separate passes for processing functions and inductives was unnecessary. This commit combines `registerInductiveDefs` and `registerFunctionDefs` into a single pass over a modules statements
paulcadman
force-pushed
the
fix-axiom-inductive-reg
branch
from
2e5a316
to
290805b
Compare
paulcadman
force-pushed
the
fix-axiom-inductive-reg
branch
from
290805b
to
830a593
Compare
janmasrovira
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builtin inductive axioms must be registered in the same pass as inductive types becuase inductive types may use builtin inductives in the types of their constructors.
The separate passes for processing functions and inductives was unnecessary. This commit combines
registerInductiveDefsandregisterFunctionDefsinto a single pass over a modules statements