New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve formatting of comments #2022
Merged
jonaprieto
merged 19 commits into
main
from
2016-formatting-stop-introducing-new-lines-between-certain-statements-comments-line-issue
Apr 24, 2023
Merged
Improve formatting of comments #2022
jonaprieto
merged 19 commits into
main
from
2016-formatting-stop-introducing-new-lines-between-certain-statements-comments-line-issue
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
2016-formatting-stop-introducing-new-lines-between-certain-statements-comments-line-issue
branch
from
April 20, 2023 14:36
5e62b64
to
f2b0c34
Compare
janmasrovira
temporarily deployed
to
github-pages
April 20, 2023 14:45
— with
GitHub Actions
Inactive
…etween-certain-statements-comments-line-issue
jonaprieto
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trim trailing whitespace
jonaprieto
deleted the
2016-formatting-stop-introducing-new-lines-between-certain-statements-comments-line-issue
branch
April 24, 2023 14:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is a work in progress towards respecting empty lines with respect to comments.
While the algorithm is supposed to work in general, I've focused on testing it on comments between statements.
See https://github.com/anoma/juvix/blob/13442eee34e230463fb4b91455a0f552531626d8/tests/positive/Format.juvix to see some examples