Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VampIR pipeline: handle booleans in the type of main #2137

Merged
merged 5 commits into from Jun 1, 2023
Merged

VampIR pipeline: handle booleans in the type of main #2137

merged 5 commits into from Jun 1, 2023

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz added enhancement New feature or request pipeline:vampir labels May 26, 2023
@lukaszcz lukaszcz added this to the 0.4 - Prague milestone May 26, 2023
@lukaszcz lukaszcz self-assigned this May 26, 2023
@lukaszcz lukaszcz marked this pull request as draft May 26, 2023 17:04
@lukaszcz lukaszcz marked this pull request as ready for review May 26, 2023 17:37
@lukaszcz lukaszcz marked this pull request as draft May 26, 2023 18:00
@lukaszcz lukaszcz marked this pull request as ready for review May 26, 2023 18:17
@lukaszcz lukaszcz mentioned this pull request May 29, 2023
Merged
@lukaszcz lukaszcz force-pushed the bool-vampir branch 2 times, most recently from 3dc6ead to 53e0dc0 Compare May 30, 2023 15:11
@jonaprieto
Copy link
Collaborator

Looks good to me.

jonaprieto
jonaprieto reviewed May 31, 2023
View reviewed changes
test/Core/Eval/Base.hs Outdated Show resolved Hide resolved
lukaszcz and others added 2 commits June 1, 2023 10:36
@lukaszcz @jonaprieto
Update src/Juvix/Compiler/Backend/VampIR/Translation/FromCore.hs
7d6e6d7 
Co-authored-by: Jonathan Cubides <jonathan.cubides@uib.no>
@lukaszcz @jonaprieto
Update test/Core/Eval/Base.hs
67458e0 
Co-authored-by: Jonathan Cubides <jonathan.cubides@uib.no>
@lukaszcz lukaszcz requested a review from jonaprieto June 1, 2023 08:38
@jonaprieto jonaprieto merged commit 757b4ed into main Jun 1, 2023
4 checks passed
@jonaprieto jonaprieto deleted the bool-vampir branch June 1, 2023 09:42
@jonaprieto jonaprieto modified the milestones: 0.4 - Prague, 0.3.5 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaprieto jonaprieto jonaprieto approved these changes

@janmasrovira janmasrovira Awaiting requested review from janmasrovira

Assignees

@lukaszcz lukaszcz

Labels
enhancement New feature or request pipeline:vampir
Projects
None yet
Milestone
0.3.5
Development

Successfully merging this pull request may close these issues.

Handle Bool as input/output of main for the VampIR pipeline
2 participants
@lukaszcz @jonaprieto