Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly scan imports inside local modules #2165

Merged
merged 3 commits into from Jun 2, 2023
Merged

Properly scan imports inside local modules #2165

merged 3 commits into from Jun 2, 2023

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Jun 2, 2023 •
edited

Nested imports where not scanned properly when building the Internal InfoTable. That is now fixed

@janmasrovira janmasrovira added this to the 0.3.5 milestone Jun 2, 2023
@janmasrovira janmasrovira self-assigned this Jun 2, 2023
@janmasrovira janmasrovira marked this pull request as ready for review June 2, 2023 09:31
jonaprieto
jonaprieto approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@jonaprieto jonaprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Back to life our examples in the documentation.

@jonaprieto jonaprieto merged commit 02e9f89 into main Jun 2, 2023
4 of 8 checks passed
@jonaprieto jonaprieto deleted the issue-2163 branch June 2, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaprieto jonaprieto jonaprieto approved these changes

Assignees

@janmasrovira janmasrovira

Labels
fix:bug
Projects
None yet
Milestone
0.3.5
Development

Successfully merging this pull request may close these issues.

Unexpected error for open imports inside local modules
2 participants
@janmasrovira @jonaprieto