Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup GasLimit #2620

Closed
grarco opened this issue Feb 15, 2024 · 2 comments · Fixed by #3124
Closed

Cleanup GasLimit #2620

grarco opened this issue Feb 15, 2024 · 2 comments · Fixed by #3124
Assignees
@grarco
Labels
breaking: tx format gas pre-mainnet Must happen before mainnet.
Milestone
Phase 1: mainnet ...

Comments

@grarco
Copy link
Contributor

grarco commented Feb 15, 2024

Since were dropping support for a future DKG implementation we can also remove the GasLimit type and just rely on Gas. We can keep a type alias for convenience if needed.
@grarco grarco added gas pre-mainnet Must happen before mainnet. labels Feb 15, 2024
@grarco grarco self-assigned this Feb 15, 2024
@brentstone brentstone added this to the To evaluate milestone Apr 6, 2024
@grarco
Copy link
Contributor Author

grarco commented Apr 11, 2024

Actually, on a second thought, since the tx must carry the units of gas (and not the subunits used in protocol) we can maybe keep this struct and just remove the associated constants and methods that we don't need anymore

@grarco grarco changed the title Remove GasLimit Cleanup GasLimit Apr 22, 2024
@cwgoes
Copy link
Contributor

cwgoes commented Apr 23, 2024

@grarco If this is just code removal, can you do it quickly?

grarco added a commit that referenced this issue Apr 24, 2024
@grarco
Changelog #2620
7401da1
@grarco grarco mentioned this issue Apr 24, 2024
Merged
2 tasks
brentstone added a commit that referenced this issue Apr 26, 2024
@brentstone
Merge branch 'grarco/clean-gas-limit' (#3124)
2268b7d 
* grarco/clean-gas-limit:
  Changelog #2620
  Cleans up `GasLimit`
brentstone added a commit that referenced this issue Apr 26, 2024
@brentstone
Merge branch 'grarco/clean-gas-limit' (#3124)
c1a3039 
* origin/grarco/clean-gas-limit:
  Changelog #2620
  Cleans up `GasLimit`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grarco grarco

Labels
breaking: tx format gas pre-mainnet Must happen before mainnet.
Projects
None yet
Milestone
Phase 1: mainnet genesis
Development

Successfully merging a pull request may close this issue.

GasLimit cleanup anoma/namada
4 participants
@Fraccaman @cwgoes @brentstone @grarco