Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track MASP anchor hashes in app hash #2794

Closed
Tracked by #2843
cwgoes opened this issue Mar 4, 2024 · 4 comments · Fixed by #3125
Closed
Tracked by #2843

Track MASP anchor hashes in app hash #2794

cwgoes opened this issue Mar 4, 2024 · 4 comments · Fixed by #3125
Assignees
@grarco
Labels
breaking: protocol MASP pre-mainnet Must happen before mainnet.
Milestone
Phase 1: mainnet ...

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Mar 4, 2024 •
edited by brentstone

Per discussion

Also may need to do this for the commitment tree.
@grarco grarco added MASP pre-mainnet Must happen before mainnet. labels Mar 4, 2024
@grarco grarco mentioned this issue Mar 12, 2024
Merged
2 tasks
@grarco grarco mentioned this issue Mar 27, 2024
Closed
16 tasks
@brentstone
Copy link
Contributor

Also consider doing this for the commitment tree

@grarco
Copy link
Contributor

grarco commented Apr 6, 2024

Yes this was intended for both the trees even though the conversion one should have already been addressed in the pr mentioned above

@cwgoes
Copy link
Contributor Author

cwgoes commented Apr 24, 2024 •
edited

We should do this in phase 1, otherwise it might require a hard fork.

@grarco is this quick?

@grarco
Copy link
Contributor

grarco commented Apr 24, 2024

Yes should be quick

grarco added a commit that referenced this issue Apr 24, 2024
@grarco
Changelog #2794
7cefdea
@grarco grarco mentioned this issue Apr 24, 2024
Merged
2 tasks
brentstone added a commit that referenced this issue Apr 24, 2024
@brentstone
Merge branch 'grarco/merkle-masp-hashes' (#3125)
a568d29 
* grarco/merkle-masp-hashes:
  Fixes merkle unit tests
  Changelog #2794
  Tests masp keys merklization
  Merklize the masp commitment tree anchor keys
brentstone added a commit that referenced this issue Apr 26, 2024
@brentstone
Merge branch 'grarco/merkle-masp-hashes' (#3125)
f10ac05 
* origin/grarco/merkle-masp-hashes:
  Fixes merkle unit tests
  Changelog #2794
  Tests masp keys merklization
  Merklize the masp commitment tree anchor keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grarco grarco

Labels
breaking: protocol MASP pre-mainnet Must happen before mainnet.
Projects
None yet
Milestone
Phase 1: mainnet genesis
Development

Successfully merging a pull request may close this issue.

Merklize commitment tree anchor keys anoma/namada
3 participants
@cwgoes @brentstone @grarco