Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no size limit on validator metadata storage #2799

Closed
thibault-ketterer opened this issue Mar 4, 2024 · 1 comment
Closed

no size limit on validator metadata storage #2799

thibault-ketterer opened this issue Mar 4, 2024 · 1 comment
Labels
bug Something isn't working validity-predicate

Comments

@thibault-ketterer
Copy link

There is an issue in the validator change metada storage
there is no size limit on the size you could store in the validator metadata fields
email / discordid / description / website / avatar

I think it may lead to problems, storage oversize, waste of BC space.

pub fn write_validator_description<S>(

I made some tests on the the only limitation I had was the tx max size, but I was able to store 1MB of "A" in the description field
but my local campfire did not crashed

I have a client that writes the 1MB of data in the desciption field you need it

just hacked cli.rs to send 1MB instead of the command line arg it received
image

I think you should truncate the data to whatever size you think is good for the different fields

note: the class S bug has been reported this night
moniker Lankou
memo tpknam1qp657jtd7tzkadzua0wqr6f5cewrlrah08fn7ny92vcfjuh3lcehvnspw8y

@thibault-ketterer thibault-ketterer added the bug Something isn't working label Mar 4, 2024
@brentstone
Copy link
Collaborator

This is also noted in #2800, with the accompanying #2845 that will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validity-predicate
Projects
None yet
Development

No branches or pull requests

3 participants