Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate, remove and disallow the usage of the floats in WASM #3298

Open
tzemanovic opened this issue May 23, 2024 · 1 comment
Open

Investigate, remove and disallow the usage of the floats in WASM #3298

tzemanovic opened this issue May 23, 2024 · 1 comment
Assignees
@tzemanovic
Labels
breaking: protocol wasm
Milestone
Nice to have and ...

Comments

@tzemanovic
Copy link
Member

tzemanovic commented May 23, 2024 •
edited
Loading

follow-up to #3275

We need to investigate, remove and disallow usage of the floats. I had a look and some usage comes from tendermint-rs and its use serde_json which should be easy to replace by serde_json_wasm. Other use in wasm tx_ibc seems to be pulled in from schemars (transitive dep of ibc) and ethbridge-structs, but those may not be an issue.

While at it, we should also replace our usage of serde_json by serde_json_wasm
@tzemanovic tzemanovic self-assigned this May 24, 2024
@tzemanovic
Copy link
Member Author

I found one of the sources of floats in tx_ibc wasm is ClientState protobuf decoding, but I tried to temp remove that code and there seem to be more than that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzemanovic tzemanovic

Labels
breaking: protocol wasm
Projects
None yet
Milestone
Nice to have and non-breaking
Development

No branches or pull requests
3 participants
@tzemanovic @cwgoes @brentstone