Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change can_send_validator_set_update logic #600

Closed
sug0 opened this issue Oct 14, 2022 · 0 comments
Closed

Change can_send_validator_set_update logic #600

sug0 opened this issue Oct 14, 2022 · 0 comments
Labels
bug Something isn't working ethereum-bridge

Comments

@sug0
Copy link
Contributor

sug0 commented Oct 14, 2022

Related with #599

Instead of sending a validator set update at the first block of an epoch, we should do this at the second block of an epoch. This is because we don't know, in advance, the first block of a new epoch until we call finalize_block(). The only exception is, of course, at genesis, where we know the height of the first block.

This change only affects ABCI++ builds of the ledger.

@sug0 sug0 added bug Something isn't working ethereum-bridge labels Oct 14, 2022
sug0 added a commit that referenced this issue Nov 2, 2022
The related issues were #599 and #600, which are fixed on the branch
leading up to this commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ethereum-bridge
Projects
None yet
Development

No branches or pull requests

2 participants