Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger --time doc #1087

Merged
merged 5 commits into from
Mar 29, 2023
Merged

Ledger --time doc #1087

merged 5 commits into from
Mar 29, 2023

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Jan 25, 2023

More detailed help message

@grarco grarco changed the title Ledger --time help Ledger --time doc Jan 25, 2023
"The start time of the ledger. Accepts a relaxed form of \
RFC3339. A space or a 'T' are accepted as the separator \
between the date and time parts. Additional spaces are \
allowed between each component.\nAll of these examples are \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; only suggestion would maybe be to either use "parts" or "components" in both sentences. Something like "... the date and time components" Eh LGTM otherwise.

@grarco grarco added documentation Improvements or additions to documentation skip-devnet-tests labels Jan 30, 2023
bengtlofgren
bengtlofgren previously approved these changes Jan 30, 2023
bengtlofgren
bengtlofgren previously approved these changes Feb 5, 2023
@tzemanovic tzemanovic merged commit 35d9c00 into main Mar 29, 2023
@tzemanovic tzemanovic deleted the grarco/time-docs branch March 29, 2023 08:19
bengtlofgren pushed a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-devnet-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants