Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx ChainId #1106

Merged
merged 46 commits into from
Apr 13, 2023
Merged

Tx ChainId #1106

merged 46 commits into from
Apr 13, 2023

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Jan 31, 2023

Addresses #1009

Based on #1017

Implements a ChainId field in Tx to ensure that a transaction is accepted only by the correct fork.

  • Adds chain_id field to struct Tx
  • Adds mempool_validate checks
  • Adds process_proposal checks
  • Unit tests

@grarco grarco mentioned this pull request Jan 31, 2023
3 tasks
@grarco
Copy link
Contributor Author

grarco commented Feb 1, 2023

pls update wasm

grarco added a commit that referenced this pull request Feb 1, 2023
@grarco grarco marked this pull request as ready for review February 2, 2023 13:57
grarco added a commit that referenced this pull request Feb 6, 2023
tzemanovic
tzemanovic previously approved these changes Feb 7, 2023
grarco added a commit that referenced this pull request Feb 8, 2023
@grarco grarco mentioned this pull request Feb 8, 2023
grarco added a commit that referenced this pull request Feb 10, 2023
@grarco
Copy link
Contributor Author

grarco commented Feb 10, 2023

pls update wasm

grarco added a commit that referenced this pull request Mar 23, 2023
grarco added a commit that referenced this pull request Mar 31, 2023
tzemanovic added a commit that referenced this pull request Apr 7, 2023
* grarco/tx-chain-id:
  changelog: add #1106
  [ci] wasm checksums update
  Manages invalid chain id for decrypted txs
  Adjusts decrypted tx conversion
  Clippy + fmt
  Unit tests for tx chain id
  Adjusts tx chain id check
  Validates tx `ChainId`
  Adds tx `chain_id` in tests
  Adds chain id in `Tx` instantiations
  Adds `ChainId` to struct `Tx`
@tzemanovic tzemanovic mentioned this pull request Apr 7, 2023
@juped juped merged commit b478601 into main Apr 13, 2023
@juped juped deleted the grarco/tx-chain-id branch April 13, 2023 06:07
bengtlofgren pushed a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants