update masp conversions via write log #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/protocol-write-log
branch
3 times, most recently
from
24ece92
to
9441d70
Compare
|
pls update wasm |
tzemanovic
added a commit
that referenced
this pull request
Feb 1, 2023
The expected keys previously omitted a newly written value, because iter prefix wasn't able to find it
To use storage_api, use WlStorage instead
tzemanovic
added a commit
that referenced
this pull request
Feb 1, 2023
tzemanovic
force-pushed
the
tomas/protocol-write-log
branch
from
da5a58b
to
27ea90b
Compare
|
pls update wasm |
tzemanovic
commented
Feb 2, 2023
There was a problem hiding this comment.
thanks @yito88 for pointing out that there are possible storage write from goverance proposal that are committed directly to DB
tzemanovic
added a commit
that referenced
this pull request
Feb 2, 2023
tzemanovic
force-pushed
the
tomas/protocol-write-log
branch
from
dc9ceb9
to
76bc07c
Compare
I added the fix for gov - I've moved the gov module from |
tzemanovic
force-pushed
the
tomas/protocol-write-log
branch
from
76bc07c
to
17427fa
Compare
|
pls update wasm |
juped
added a commit
that referenced
this pull request
Feb 10, 2023
* tomas/protocol-write-log: [ci] wasm checksums update changelog: add #1108 shell/queries: refactor token query using storage_api token mod shell/gov: apply changes via `WlStorage` write log test/finalize_block: ensure that proposal doesn't commit to DB gov + token: refactor using storage_api move gov mod from tx_prelude to core storage_api test/test_vp_host_env: update to write via tx ledger: apply `update_allowed_conversions` storage changes via WlStorage wl_storage: apply protocol write log changes at block level test/ledger/shell: test that `finalize_block` doesn't commit storage
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #913
This PR Improves the
WlStorageto write protocol changes via block-level write log. This is then used to make sure that no storage changes are committed in ABCIFinalizeBlockrequest handler and only in theCommithandler.