PoS: fix tendermint inactive validator set update - 0.14.0 #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juped
force-pushed
the
tomas/tm-validator-set-update
branch
from
16e1f10
to
ec8882c
Compare
|
rewound by 1 commit; the wip tests are available at tomas/validator-set-update-tests |
|
pls update wasm |
brentstone
reviewed
Feb 15, 2023
| ) | ||
| .unwrap(); | ||
|
|
||
| update_validator_deltas(s, ¶ms, addr, stake.change(), epoch) |
There was a problem hiding this comment.
is it useful at all (for consistency) to update total deltas too? Maybe not necessary for the test.
There was a problem hiding this comment.
it's needed for the validator_set_update_tendermint checks as it relies on the data to determine the updates
|
pls spawn devnet [anoma-devnet-draft,3,heliaxdev@1be9883,ON] |
|
Devnet with chain id |
juped
added a commit
that referenced
this pull request
Feb 21, 2023
* tomas/tm-validator-set-update: test/PoS: add one more test case for TM validator set update changelog: add #1146 wasm: update checksums PoS: turn prints into tracing::debug in validator_set_update_tendermint PoS: fix skipping 0 voting power prev. consensus validators in TM update test/PoS: test tendermint validator set updates PoS: fix update_validator_set to update validator's state accordingly pos/types: add PartialEq on ValidatorSetUpdate and ConsensusValidator pos: refactor validator_set_update_tendermint to make easier to test
|
pls spawn devnet [anoma-devnet-draft,3,heliaxdev@1be9883,ON] |
|
Devnet with chain id |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forward port of #1144 for 0.14.0