Fix update_data for epoched data
#1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas+brent/fix_update_data_epoched
branch
5 times, most recently
from
3b199ec
to
98d5dab
Compare
Avoid trimming data when there are no epochs to clear and write last update epoch even if no trimming occurs.
tzemanovic
force-pushed
the
tomas+brent/fix_update_data_epoched
branch
from
98d5dab
to
9f996f1
Compare
|
pls update wasm |
tzemanovic
approved these changes
May 5, 2023
tzemanovic
added a commit
that referenced
this pull request
May 5, 2023
* tomas+brent/fix_update_data_epoched: changelog: #1325 [ci] wasm checksums update pos/epoched: fix update_data methods pos/epoched: add a test for epoched data trimming ci: add GITHUB_TOKEN to protoc installation to avoid GH API rate limit Update README.md
Closed
tzemanovic
added a commit
that referenced
this pull request
May 9, 2023
* tomas+brent/fix_update_data_epoched: changelog: #1325 [ci] wasm checksums update pos/epoched: fix update_data methods pos/epoched: add a test for epoched data trimming
juped
added a commit
that referenced
this pull request
May 12, 2023
* tag 'v0.15.2': Namada 0.15.2 changelog: add #1218 fix description add changelog changelog: #1325 [ci] wasm checksums update pos/epoched: fix update_data methods pos/epoched: add a test for epoched data trimming fix table options fix rollback fix dump_db column families added changelog small fixes fix `test_init_genesis` failure due to validator ordering test/pos: add a seed for failing `test_init_genesis` test case test/pos/bonds: fix failing cases test: set verbose = 1 for state machine tests test: update to new proptest state machine testing branch enable rocksdb wal and batch once fix: review comments added changelog [ci] wasm checksums update core/storage_api/lazy_map: fix `iter` for map with nested collections core/storage_api/collections: add `is_data_sub_key` helper method core/storage_api: add predicate filtering version of prefix_iter test/lazy_vec: add test case to reproduce nested collection iter issue changelog: #1295 cargo: enable overflow-checks in release build update tonic [ci] wasm checksums update for CI update ibc-rs to v0.36.0+ revert epoch_per_year in test genesis use ibc-rs validate_self_tendermint_client fix the receive key and add unit tests add match_value() and fix a unit test for timeout for CI [ci] wasm checksums update update ibc-rs to 0.32.0 update tower-abci fix wasm_for_tests deps fix E2E test WIP: for clippy WIP: restore denom WIP: fix tests WIP: fix unit tests for IBC VP WIP: fix tests WIP: add context file WIP: emit multiple IBC events WIP: store denom in IBC execution WIP: IbcAction and TransferModule have Rc<RefCell<C>> WIP: upgrade ibc-rs to v0.31.0 WIP: fix denom validation WIP: add IbcCommonContext WIP: fix tests/src/vm_host_env/ibc.rs WIP: fix vp_get_block_header WIP: fix IBC VP WIP: fix IBC VP for denom store WIP: fix IBC token VP WIP: get_block_header WIP: implementing IBC VP and tx WIP: implement TokenTransferContext WIP: implementing TokenTransferContext WIP: implement Module WIP: upgrade ibc-rs to 0.29.0 WIP: implement ExecutionContext WIP: restore read_counter and read_sequence WIP: add context dir WIP: impl ValidationContext WIP: resolve dependences for new ibc-rs fix: review comments format ledger: added utils to convert pk to tendermint address fix: doc strings fix: use data_dir ledger: default folder in home directory
juped
added a commit
that referenced
this pull request
May 12, 2023
…hed' into ray/sdk-wip * namada/tomas+brent/fix_update_data_epoched: changelog: #1325 [ci] wasm checksums update pos/epoched: fix update_data methods pos/epoched: add a test for epoched data trimming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both
EpochedandEpochedDeltaobjects, there are improvements that can be made to the functionupdate_data. The base is currently #892 because a bug in the existing changes is exposed in thepos_state_machine_test.