checked masp params in node #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juped
commented
Jun 26, 2023
juped
commented
- masp: deduplicate parameters loading
- masp: check size and hash of params in node
juped
commented
Jun 26, 2023
| @@ -373,7 +335,7 @@ impl<P1, R1, N1> | |||
|
|
|||
| /// Abstracts platform specific details away from the logic of shielded pool | |||
| /// operations. | |||
| #[async_trait(?Send)] | |||
| #[async_trait(? Send)] | |||
There was a problem hiding this comment.
why the hell did fmt do this
juped
force-pushed
the
ray/masp-checked
branch
4 times, most recently
from
c826802
to
26ad3d3
Compare
adrianbrink
reviewed
Jun 27, 2023
| || paths.convert != convert_path | ||
| || paths.output != output_path | ||
| { | ||
| panic!( |
There was a problem hiding this comment.
This needs to be fixed in the future. We shouldn't panic but rather return an error, because otherwise consumers of the SDK can't really handle these failures with error messages.
There was a problem hiding this comment.
this is in the node, not the sdk
|
Did you verify that the hashes here are correct? |
grarco
approved these changes
Jun 27, 2023
Fraccaman
approved these changes
Jun 27, 2023
juped
added a commit
that referenced
this pull request
Jun 28, 2023
* ray/masp-checked: changelog: add #1619 masp: check size and hash of params in node masp: deduplicate parameters loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.