fix transparent balance query #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yito88
approved these changes
Jul 24, 2023
Fraccaman
added a commit
that referenced
this pull request
Jul 26, 2023
* origin/tomas/fix-balance-query: changelog: add #1751 apps/client/rpc: fix transparent balance query without explicit token test/e2e/tx_and_queries: add check for balance without explicit token apps/client/utils/init_network: remove redundant add address call apps/wallet: fix add genesis addresses to add token VP types apps/client/rpc: replace lookup alias with method from wallet shared/wallet: add fns to lookup aliases and tokens apps/cli/context: rm unused functions
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes:
These 2 issues together affected the transparent balance query when an owner address is specified but no explicit token is given.
Added an e2e test to cover this query.
Indicate on which release or other PRs this topic is based on
v0.20.0
Checklist before merging to
draft