Never overwrite recent Bridge pool proofs in storage #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
previously approved these changes
Sep 15, 2023
Closed
tzemanovic
reviewed
Sep 18, 2023
tzemanovic
previously approved these changes
Sep 18, 2023
Co-authored-by: Tomas Zemanovic <tomas@heliax.dev>
sug0
force-pushed
the
tiago/bridge-pool-roots-signing
branch
from
fd2965d
to
d854be0
Compare
sug0
added a commit
that referenced
this pull request
Sep 21, 2023
Closed
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/tiago/bridge-pool-roots-signing: Changelog for #1893 Declare returned storage key as must use Add debug logs for discarded Bridge pool root proofs Return immediately if a BP proof is already available Write test_more_recent_signed_root_not_overwritten() unit test Add Debug to Bridge pool root tallies Only update a signed BP root in storage if it is newer than old root Parameterize signed Bridge pool root by its block height New method to append segments to a storage key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Only write signed Bridge pool proofs to storage if they are more recent than the previously available proof in storage.
Indicate on which release or other PRs this topic is based on
v0.22.0Checklist before merging to
draft