masp: move to native VP #2051
Merged
masp: move to native VP #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juped
force-pushed
the
ray/native-masp
branch
7 times, most recently
from
3510fcf
to
78cd5f0
Compare
grarco
reviewed
Nov 9, 2023
| @@ -466,94 +463,5 @@ fn vp_validator(c: &mut Criterion) { | |||
| group.finish(); | |||
| } | |||
|
|
|||
| fn vp_masp(c: &mut Criterion) { | |||
There was a problem hiding this comment.
We should move this benchmark to benches/native_vps
grarco
reviewed
Nov 9, 2023
| _ => {} | ||
| } | ||
| // Verify the proofs. | ||
| Ok(verify_shielded_tx(&shielded_tx)) |
There was a problem hiding this comment.
It would be nice to benchmark this function (I think this is the most computationally expensive one) and charge some gas before calling it in here
|
namada/shared/src/vm/wasm/host_env.rs Line 132 in 3a0ecd8 I believe we don't need this host fn anymore |
grarco
reviewed
Nov 9, 2023
sdk/src/signing.rs
Outdated
| return Err(Error::from(TxError::InvalidAccount(owner.encode()))); | ||
| Some(owner @ Address::Internal(internal)) => { | ||
| match internal { | ||
| // TODO use sentinel? |
There was a problem hiding this comment.
I don't think we need a signature on the transaction at all if the source is the MASP cause no VP would check it anyway
grarco
force-pushed
the
ray/native-masp
branch
from
9c08c70
to
bb70c02
Compare
Closed
grarco
force-pushed
the
ray/native-masp
branch
from
bb70c02
to
b64a5c8
Compare
grarco
force-pushed
the
ray/native-masp
branch
from
b64a5c8
to
2c9c095
Compare
grarco
force-pushed
the
ray/native-masp
branch
from
2c9c095
to
09f1be0
Compare
Closed
grarco
force-pushed
the
ray/native-masp
branch
from
09f1be0
to
2a12afe
Compare
adrianbrink
added a commit
that referenced
this pull request
Nov 14, 2023
* ray/native-masp: Changelog #2051 Updates masp test proofs Removes unused masp check from `vp_user` Updates benches with masp native vp Removes masp vp from genesis files Moves masp vp to native
adrianbrink
added a commit
that referenced
this pull request
Nov 14, 2023
* ray/native-masp: Changelog #2051 Updates masp test proofs Removes unused masp check from `vp_user` Updates benches with masp native vp Removes masp vp from genesis files Moves masp vp to native
Closed
grarco
added a commit
that referenced
this pull request
Nov 14, 2023
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/ray/native-masp: Updates masp proofs for testing Updates alias for masp native vp Changelog #2051 Updates masp test proofs Removes unused masp check from `vp_user` Updates benches with masp native vp Removes masp vp from genesis files Moves masp vp to native
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/ray/native-masp: Updates masp proofs for testing Updates alias for masp native vp Changelog #2051 Updates masp test proofs Removes unused masp check from `vp_user` Updates benches with masp native vp Removes masp vp from genesis files Moves masp vp to native
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/ray/native-masp: Updates masp proofs for testing Updates alias for masp native vp Changelog #2051 Updates masp test proofs Removes unused masp check from `vp_user` Updates benches with masp native vp Removes masp vp from genesis files Moves masp vp to native
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/ray/native-masp: Updates masp proofs for testing Updates alias for masp native vp Changelog #2051 Updates masp test proofs Removes unused masp check from `vp_user` Updates benches with masp native vp Removes masp vp from genesis files Moves masp vp to native
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #1924.
Moves the masp vp to native. Removes the now useless host env for masp validation and updates gas accounting and cost. Updated the masp vp benchmarks.
Indicate on which release or other PRs this topic is based on
commit 3a0ecd8 (v0.25.0)
Checklist before merging to
draft