Fix governance bugs #2133
Merged
Fix governance bugs #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwgoes
reviewed
Nov 8, 2023
| @@ -830,22 +830,23 @@ where | |||
| pgf_fundings.sort_by(|a, b| a.id.cmp(&b.id)); | |||
|
|
|||
| for funding in pgf_fundings { | |||
| if credit_tokens( | |||
| if storage_api::token::transfer( | |||
There was a problem hiding this comment.
I don't think this is complete, we also need to update/change https://github.com/anoma/namada/blob/main/apps/src/lib/node/ledger/shell/finalize_block.rs#L858 - I think we can actually use credit_tokens there, but then we shouldn't send the steward inflation to the PGF account in the first place (https://github.com/anoma/namada/blob/main/apps/src/lib/node/ledger/shell/finalize_block.rs#L812)
Fraccaman
reviewed
Nov 9, 2023
shared/src/ledger/governance/mod.rs
Outdated
| ) -> Result<bool> { | ||
| let bond_handle = pos::namada_proof_of_stake::bond_handle( | ||
| Ok(pos::namada_proof_of_stake::is_delegator( |
There was a problem hiding this comment.
I think we could also add a check if address != delegation_address
Closed
cwgoes
previously approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #1107.
Fixes the
is_delegatorfunction in the governance vp which could return true also for validators with self bonds.Corrects the inflation mechanism for pgf.
Indicate on which release or other PRs this topic is based on
Commit 3a0ecd8 on
base(v0.25.0)Checklist before merging to
draft