Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of previous PoS inflation data #2559

Merged
merged 2 commits into from Apr 12, 2024

Conversation

brentstone
Copy link
Contributor

@brentstone brentstone commented Feb 7, 2024

Describe your changes

Closes #2556. These values have been removed from Parameters and are now initialized in proof_of_stake::init_genesis. Their storage keys have also been moved under the PoS address storage space.

Indicate on which release or other PRs this topic is based on

v0.32.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

This was referenced Feb 7, 2024
brentstone added a commit that referenced this pull request Feb 8, 2024
brentstone added a commit that referenced this pull request Feb 8, 2024
* brent/remove-pos-inflation-from-params:
  changelog: add #2559
  refactor handling of previous PoS inflation data
@tzemanovic tzemanovic mentioned this pull request Feb 9, 2024
brentstone added a commit that referenced this pull request Feb 11, 2024
@brentstone brentstone force-pushed the brent/remove-pos-inflation-from-params branch from 07780c6 to 9d409a0 Compare February 11, 2024 04:10
tzemanovic
tzemanovic previously approved these changes Feb 15, 2024
tzemanovic added a commit that referenced this pull request Feb 15, 2024
* origin/brent/remove-pos-inflation-from-params:
  changelog: add #2559
  refactor handling of previous PoS inflation data
tzemanovic added a commit that referenced this pull request Feb 15, 2024
* origin/brent/remove-pos-inflation-from-params:
  changelog: add #2559
  refactor handling of previous PoS inflation data
brentstone added a commit that referenced this pull request Feb 23, 2024
brentstone added a commit that referenced this pull request Feb 23, 2024
@brentstone brentstone force-pushed the brent/remove-pos-inflation-from-params branch from 9d409a0 to f0f4333 Compare February 23, 2024 20:32
brentstone added a commit that referenced this pull request Feb 23, 2024
@brentstone brentstone force-pushed the brent/remove-pos-inflation-from-params branch from f0f4333 to 9f42b04 Compare February 23, 2024 20:40
@brentstone brentstone mentioned this pull request Feb 23, 2024
2 tasks
brentstone added a commit that referenced this pull request Feb 28, 2024
@brentstone brentstone force-pushed the brent/remove-pos-inflation-from-params branch from 9f42b04 to 85a0bbb Compare February 28, 2024 05:01
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.46%. Comparing base (61a0759) to head (fdd0de8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2559      +/-   ##
==========================================
+ Coverage   53.44%   53.46%   +0.01%     
==========================================
  Files         310      310              
  Lines      101574   101563      -11     
==========================================
+ Hits        54288    54297       +9     
+ Misses      47286    47266      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brentstone added a commit that referenced this pull request Mar 3, 2024
@brentstone brentstone force-pushed the brent/remove-pos-inflation-from-params branch from 46c88c0 to fdd0de8 Compare April 3, 2024 05:22
brentstone added a commit that referenced this pull request Apr 3, 2024
…t+pos

* brent/remove-pos-inflation-from-params:
  changelog: add #2559
  refactor handling of previous PoS inflation data
  Namada 0.32.1
  remove vp user hash from SE
  build migrations in release runtime
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/brent/remove-pos-inflation-from-params:
  changelog: add #2559
  refactor handling of previous PoS inflation data

# Conflicts:
#	crates/apps/src/lib/node/ledger/shell/mod.rs
#	crates/shielded_token/src/conversion.rs
@tzemanovic tzemanovic merged commit a2876b7 into main Apr 12, 2024
18 of 19 checks passed
@tzemanovic tzemanovic deleted the brent/remove-pos-inflation-from-params branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove parameters which are not parameters
3 participants