Fix epoched last update #2667
Merged
Fix epoched last update #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2667 +/- ##
==========================================
- Coverage 53.88% 53.87% -0.02%
==========================================
Files 308 308
Lines 100154 100161 +7
==========================================
- Hits 53966 53959 -7
- Misses 46188 46202 +14 ☔ View full report in Codecov by Sentry. |
brentstone
force-pushed
the
brent/fix-last-update-usage
branch
2 times, most recently
from
49d1cfe
to
92b6353
Compare
brentstone
added a commit
that referenced
this pull request
Feb 24, 2024
tzemanovic
reviewed
Feb 26, 2024
Comment on lines
+2705
to
+2704
| let start = validator_set_update_epoch | ||
| .0 | ||
| .checked_sub(current_epoch.0) |
There was a problem hiding this comment.
Suggested change
| let start = validator_set_update_epoch | |
| .0 | |
| .checked_sub(current_epoch.0) | |
| let start = validator_set_update_epoch | |
| .checked_sub(current_epoch) |
tzemanovic
approved these changes
Feb 26, 2024
brentstone
added a commit
that referenced
this pull request
Feb 28, 2024
brentstone
force-pushed
the
brent/fix-last-update-usage
branch
from
b8e3493
to
107f5cd
Compare
brentstone
added a commit
that referenced
this pull request
Mar 3, 2024
brentstone
force-pushed
the
brent/fix-last-update-usage
branch
from
107f5cd
to
487bb36
Compare
brentstone
force-pushed
the
brent/fix-last-update-usage
branch
from
487bb36
to
0f85396
Compare
10 tasks
tzemanovic
added a commit
that referenced
this pull request
Mar 19, 2024
* origin/brent/fix-last-update-usage: changelog: add #2667 properly update a simple epoched object considering last update fix last update for nested epoched objects
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/brent/fix-last-update-usage: changelog: add #2667 properly update a simple epoched object considering last update fix last update for nested epoched objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2665.
Indicate on which release or other PRs this topic is based on
v0.31.9
Checklist before merging to
draft