Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how masp tx's are identified #2790

Merged
merged 2 commits into from Apr 27, 2024
Merged

Fix how masp tx's are identified #2790

merged 2 commits into from Apr 27, 2024

Conversation

batconjurer
Copy link
Member

@batconjurer batconjurer commented Mar 3, 2024

Describe your changes

Resolves issue #2684

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@batconjurer batconjurer requested a review from grarco March 3, 2024 15:48
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (97ec5b4) to head (f43e333).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2790   +/-   ##
=======================================
  Coverage   59.39%   59.40%           
=======================================
  Files         298      298           
  Lines       92771    92770    -1     
=======================================
+ Hits        55104    55106    +2     
+ Misses      37667    37664    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grarco
grarco previously approved these changes Mar 3, 2024
@grarco grarco linked an issue Mar 6, 2024 that may be closed by this pull request
@Fraccaman Fraccaman mentioned this pull request Apr 15, 2024
brentstone added a commit that referenced this pull request Apr 17, 2024
* bat/fix/issue-2684:
  [chore]: Added changelog
  [fix]: Fix how masp txes are identified
@brentstone brentstone merged commit 34841b0 into main Apr 27, 2024
18 of 19 checks passed
@brentstone brentstone deleted the bat/fix/issue-2684 branch April 27, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify MASP validity flag
3 participants