Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor governance #2803

Merged
merged 7 commits into from Apr 12, 2024
Merged

Refactor governance #2803

merged 7 commits into from Apr 12, 2024

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Mar 4, 2024

Describe your changes

Indicate on which release or other PRs this topic is based on

v0.32.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 93.84211% with 117 lines in your changes are missing coverage. Please review.

Project coverage is 55.16%. Comparing base (5e0b162) to head (11ffc77).

Files Patch % Lines
crates/apps/src/lib/client/rpc.rs 0.00% 32 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/governance.rs 16.00% 21 Missing ⚠️
crates/governance/src/storage/proposal.rs 0.00% 13 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 13 Missing ⚠️
crates/apps/src/lib/cli.rs 0.00% 10 Missing ⚠️
crates/namada/src/ledger/governance/mod.rs 99.70% 5 Missing ⚠️
crates/sdk/src/lib.rs 0.00% 5 Missing ⚠️
crates/governance/src/storage/mod.rs 0.00% 4 Missing ⚠️
crates/sdk/src/args.rs 0.00% 3 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2803      +/-   ##
==========================================
+ Coverage   53.44%   55.16%   +1.71%     
==========================================
  Files         310      309       -1     
  Lines      101574   102672    +1098     
==========================================
+ Hits        54288    56640    +2352     
+ Misses      47286    46032    -1254     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the fraccaman/remove-offline-governance branch from c6414e6 to 23ea88d Compare March 5, 2024 12:20
@Fraccaman Fraccaman force-pushed the fraccaman/remove-offline-governance branch from e8728d7 to 5126abf Compare March 5, 2024 17:47
@brentstone brentstone mentioned this pull request Mar 6, 2024
2 tasks
@brentstone brentstone force-pushed the fraccaman/remove-offline-governance branch 2 times, most recently from f7d40e1 to 086fd62 Compare March 14, 2024 15:12
brentstone added a commit that referenced this pull request Mar 15, 2024
@brentstone brentstone marked this pull request as ready for review March 15, 2024 22:06
tzemanovic added a commit that referenced this pull request Mar 19, 2024
* origin/fraccaman/remove-offline-governance:
  changelog: add #2803
  fmt + clippy
  more tests
  added unit tests
  fix governance vp
  remove offline governance, refactor tally types
@brentstone brentstone force-pushed the fraccaman/remove-offline-governance branch from 674fe02 to 5702319 Compare March 19, 2024 16:23
tzemanovic added a commit that referenced this pull request Apr 1, 2024
* origin/brent/fix-val-voting-no-self-bonds:
  fmt
  fix rebase
  remove unnecessary epoch query
  changelog: add #2877
  fix client bug preventing a validator with no self-bonds from voting
  fmt
  changelog: add #2803
  fmt + clippy
  more tests
  added unit tests
  fix governance vp
  remove offline governance, refactor tally types
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/fraccaman/remove-offline-governance:
  fmt
  changelog: add #2803
  fmt + clippy
  more tests
  added unit tests
  fix governance vp
  remove offline governance, refactor tally types

# Conflicts:
#	crates/apps/src/lib/client/tx.rs
@tzemanovic tzemanovic merged commit 63cb360 into main Apr 12, 2024
17 of 19 checks passed
@tzemanovic tzemanovic deleted the fraccaman/remove-offline-governance branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

governance: remove offline proposal code
3 participants