Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC tx - simplify storage iter prefix #2848

Merged
merged 2 commits into from Apr 12, 2024
Merged

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Mar 8, 2024

Describe your changes

closes #2827

Indicate on which release or other PRs this topic is based on

0.31.9

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic marked this pull request as ready for review March 8, 2024 09:37
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.93%. Comparing base (2ba001d) to head (d87aa92).
Report is 131 commits behind head on main.

Files Patch % Lines
crates/namada/src/vm/host_env.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2848      +/-   ##
==========================================
+ Coverage   53.88%   53.93%   +0.05%     
==========================================
  Files         308      308              
  Lines      100154   100053     -101     
==========================================
- Hits        53966    53965       -1     
+ Misses      46188    46088     -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tzemanovic added a commit that referenced this pull request Mar 19, 2024
* origin/tomas/ibc-tx-simplify:
  changelog: add #2848
  ibc/tx: rm compatibility wrapper
tzemanovic added a commit that referenced this pull request Mar 28, 2024
* tomas/ibc-tx-simplify:
  changelog: add #2848
  ibc/tx: rm compatibility wrapper
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/tomas/ibc-tx-simplify:
  changelog: add #2848
  ibc/tx: rm compatibility wrapper

# Conflicts:
#	crates/namada/src/vm/host_env.rs
@tzemanovic tzemanovic merged commit 5eb9c10 into main Apr 12, 2024
15 of 17 checks passed
@tzemanovic tzemanovic deleted the tomas/ibc-tx-simplify branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove the additional write log access in IBC tx StorageRead::iter_next impl
2 participants