Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint datetime #2849

Merged
merged 4 commits into from Apr 12, 2024
Merged

lint datetime #2849

merged 4 commits into from Apr 12, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Mar 8, 2024

Describe your changes

closes #2793 - any usage of current date/time methods requires an explicit #[allow(clippy::disallowed_methods)]

Indicate on which release or other PRs this topic is based on

0.31.9

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic changed the title Tomas/lint datetime lint datetime Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 53.88%. Comparing base (2ba001d) to head (651ee7e).
Report is 131 commits behind head on main.

Files Patch % Lines
crates/apps/src/lib/node/ledger/broadcaster.rs 0.00% 7 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 7 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 5 Missing ⚠️
crates/sdk/src/eth_bridge/bridge_pool.rs 0.00% 4 Missing ⚠️
crates/sdk/src/eth_bridge/mod.rs 0.00% 4 Missing ⚠️
...ates/apps/src/lib/node/ledger/shims/abcipp_shim.rs 0.00% 3 Missing ⚠️
crates/apps/src/bin/namada-node/cli.rs 0.00% 2 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 2 Missing ⚠️
crates/sdk/src/eth_bridge/validator_set.rs 0.00% 1 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2849   +/-   ##
=======================================
  Coverage   53.88%   53.88%           
=======================================
  Files         308      308           
  Lines      100154   100225   +71     
=======================================
+ Hits        53966    54008   +42     
- Misses      46188    46217   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic marked this pull request as ready for review March 8, 2024 10:03
@tzemanovic tzemanovic requested a review from sug0 March 8, 2024 10:18
sug0
sug0 previously approved these changes Mar 8, 2024
Copy link
Contributor

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good to me, just left a comment

clippy.toml Show resolved Hide resolved
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
tzemanovic added a commit that referenced this pull request Mar 19, 2024
* origin/tomas/lint-datetime:
  Update clippy.toml
  changelog: add #2849
  clippy: allow annotate every current date/time usage
  clippy: disallow method to get current date/time
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/tomas/lint-datetime:
  Update clippy.toml
  changelog: add #2849
  clippy: allow annotate every current date/time usage
  clippy: disallow method to get current date/time

# Conflicts:
#	clippy.toml
@tzemanovic tzemanovic merged commit 4d53cee into main Apr 12, 2024
12 of 19 checks passed
@tzemanovic tzemanovic deleted the tomas/lint-datetime branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit for all uses of datetime::Now in the codebase
2 participants