Improve UX of validator's address #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/validator-addresses-ux
branch
from
7195353
to
dd7affa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3093 +/- ##
==========================================
- Coverage 59.40% 59.39% -0.01%
==========================================
Files 298 298
Lines 92771 92783 +12
==========================================
- Hits 55109 55107 -2
- Misses 37662 37676 +14 ☔ View full report in Codecov by Sentry. |
Closed
sug0
requested changes
Apr 19, 2024
tzemanovic
reviewed
Apr 19, 2024
sug0
requested changes
Apr 19, 2024
brentstone
force-pushed
the
brent/validator-addresses-ux
branch
from
03006d8
to
d2860d5
Compare
brentstone
force-pushed
the
brent/validator-addresses-ux
branch
from
d2860d5
to
3e4df7f
Compare
brentstone
force-pushed
the
brent/validator-addresses-ux
branch
from
18f38ed
to
9d90736
Compare
brentstone
force-pushed
the
brent/validator-addresses-ux
branch
from
9d90736
to
193d3ce
Compare
tzemanovic
previously approved these changes
Apr 23, 2024
sug0
previously approved these changes
Apr 23, 2024
brentstone
added a commit
that referenced
this pull request
Apr 23, 2024
* brent/validator-addresses-ux: edit ck msg fix tests fix comments again changelog: add #3093 fixes from comments add post-genesis validator address to wallet with alias add pre-genesis validator address to wallet with an alias better logging
brentstone
added a commit
that referenced
this pull request
Apr 23, 2024
* brent/validator-addresses-ux: edit ck msg fix tests fix comments again changelog: add #3093 fixes from comments add post-genesis validator address to wallet with alias add pre-genesis validator address to wallet with an alias better logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2822
Indicate on which release or other PRs this topic is based on
v0.33.0
Checklist before merging to
draft