Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm block hash that was always empty #3136

Merged
merged 3 commits into from Apr 27, 2024
Merged

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Apr 25, 2024

Describe your changes

closes #3134

Indicate on which release or other PRs this topic is based on

v0.33.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

tzemanovic added a commit that referenced this pull request Apr 25, 2024
@tzemanovic tzemanovic marked this pull request as ready for review April 25, 2024 12:06
@tzemanovic tzemanovic requested a review from sug0 April 25, 2024 12:06
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 59.34%. Comparing base (97ec5b4) to head (c2eccab).
Report is 10 commits behind head on main.

Files Patch % Lines
crates/storage/src/mockdb.rs 0.00% 18 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 1 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
- Coverage   59.39%   59.34%   -0.06%     
==========================================
  Files         298      298              
  Lines       92771    92532     -239     
==========================================
- Hits        55104    54914     -190     
+ Misses      37667    37618      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tzemanovic added a commit that referenced this pull request Apr 25, 2024
@tzemanovic tzemanovic force-pushed the tomas/rm-end-block-empty-hash branch from 0e11633 to eafccfd Compare April 25, 2024 16:09
@brentstone brentstone mentioned this pull request Apr 25, 2024
@tzemanovic tzemanovic force-pushed the tomas/rm-end-block-empty-hash branch from 98b2082 to c2eccab Compare April 26, 2024 08:38
tzemanovic added a commit that referenced this pull request Apr 26, 2024
* tomas/rm-end-block-empty-hash:
  changelog: add #3136
  test/e2e: fix expected `client block` output
  rm block hash that was always empty
@brentstone brentstone merged commit a3c2cba into main Apr 27, 2024
18 of 19 checks passed
@brentstone brentstone deleted the tomas/rm-end-block-empty-hash branch April 27, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove empty hash from abcipp_shim EndBlock handler
2 participants