-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DI - shielded token #3466
base: main
Are you sure you want to change the base?
DI - shielded token #3466
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3466 +/- ##
==========================================
+ Coverage 53.48% 54.38% +0.89%
==========================================
Files 320 322 +2
Lines 110000 111555 +1555
==========================================
+ Hits 58832 60667 +1835
+ Misses 51168 50888 -280 ☔ View full report in Codecov by Sentry. |
44421be
to
ecfe104
Compare
Looks good to me except for the compilation issue with wasm tests |
ah, thx I missed this all the way back in the #3402 base |
ecfe104
to
061382b
Compare
49088fa
to
0028817
Compare
0028817
to
7f87875
Compare
Describe your changes
Dependency injection for the shielded token - rm'ing cross-system dep on:
The newly added test
crates/systems/src/test.rs
ensures that there are no cross-deps between these systems. More to be added as they are refactored.Indicate on which release or other PRs this topic is based on
#3472
Checklist before merging to
draft