Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI - shielded token #3466

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open

DI - shielded token #3466

wants to merge 48 commits into from

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jun 28, 2024

Describe your changes

Dependency injection for the shielded token - rm'ing cross-system dep on:

  • parameters
  • trans_token

The newly added test crates/systems/src/test.rs ensures that there are no cross-deps between these systems. More to be added as they are refactored.

Indicate on which release or other PRs this topic is based on

#3472

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 62.58566% with 819 lines in your changes missing coverage. Please review.

Project coverage is 54.38%. Comparing base (8479d38) to head (7f87875).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/ibc/src/lib.rs 14.96% 324 Missing ⚠️
crates/shielded_token/src/vp.rs 0.00% 76 Missing ⚠️
crates/node/src/shell/testing/node.rs 0.00% 48 Missing ⚠️
crates/vm/src/wasm/run.rs 10.41% 43 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 39 Missing ⚠️
crates/apps_lib/src/client/rpc.rs 0.00% 36 Missing ⚠️
crates/node/src/dry_run_tx.rs 74.54% 28 Missing ⚠️
crates/node/src/protocol.rs 61.42% 27 Missing ⚠️
crates/apps_lib/src/client/tx.rs 0.00% 21 Missing ⚠️
crates/ibc/src/context/common.rs 81.81% 20 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3466      +/-   ##
==========================================
+ Coverage   53.48%   54.38%   +0.89%     
==========================================
  Files         320      322       +2     
  Lines      110000   111555    +1555     
==========================================
+ Hits        58832    60667    +1835     
+ Misses      51168    50888     -280     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic force-pushed the tomas/di-shielded-token branch 3 times, most recently from 44421be to ecfe104 Compare July 3, 2024 15:34
@tzemanovic tzemanovic marked this pull request as ready for review July 3, 2024 15:51
@tzemanovic tzemanovic requested a review from grarco July 3, 2024 15:52
@tzemanovic tzemanovic mentioned this pull request Jul 3, 2024
4 tasks
@grarco
Copy link
Contributor

grarco commented Jul 5, 2024

Looks good to me except for the compilation issue with wasm tests

@tzemanovic
Copy link
Member Author

Looks good to me except for the compilation issue with wasm tests

ah, thx I missed this all the way back in the #3402 base

tzemanovic added a commit that referenced this pull request Jul 9, 2024
tzemanovic added a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants