Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit VP #592

Merged
merged 15 commits into from Nov 30, 2022
Merged

implicit VP #592

merged 15 commits into from Nov 30, 2022

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Oct 13, 2022

closes #8

TODO:

  • add a tx to reveal PK
  • handle PK reveal in vp_implicit (checks that address derived from the given PK matches the VP's address)
  • submit reveal tx automatically in the client when using implicit account as an inner tx signer when its PK is not yet revealed
  • add cli command to submit a tx to reveal PK manually

@tzemanovic tzemanovic force-pushed the tomas/implicit-vps branch 2 times, most recently from 56f5629 to c045db2 Compare October 13, 2022 16:46
@tzemanovic
Copy link
Member Author

pls update wasm

@tzemanovic tzemanovic marked this pull request as ready for review October 31, 2022 16:49
@tzemanovic tzemanovic requested a review from juped November 2, 2022 11:13
@tzemanovic tzemanovic added this to the v0.11.0 milestone Nov 16, 2022
tzemanovic added a commit that referenced this pull request Nov 16, 2022
- fix imports in `shared/src/ledger/storage/mod.rs`
- update token XAN -> NAM in
  - `tests/src/e2e/ledger_tests.rs`
  - `wasm/wasm_source/src/vp_implicit.rs`
- remove NFT from `wasm/wasm_source/src/vp_implicit.rs`
- added shielded token transfer params in test in
  - `wasm/wasm_source/src/vp_implicit.rs`

* tomas/implicit-vps:
  changelog: add #592
  [ci] wasm checksums update
  test/e2e: add test for implicit account's PK revealing
  add manual "reveal-pk" command and automatically reveal when needed
  vp_prelude: refactor `key::get` to re-use new `storage_api::key::get`
  wasm/vp_implicit: add support and tests for revealing PK
  wasm: add tx_reveal_pk
  test/wasm/vp_implicit: use implicit addresses as vp_owner
  wasm/vp_implicit: rm change handling from implicit VP
  test/e2e: add test for transfer from implicit account
  protocol: allow to use implicit accounts in inner txs
  storage: load implicit VP from parameters
  add implicit_vp to protocol parameters and genesis
  wasm: add vp_implicit from a copy of vp_user
@tzemanovic tzemanovic mentioned this pull request Nov 16, 2022
tzemanovic added a commit that referenced this pull request Nov 17, 2022
* tomas/implicit-vps:
  Update shared/src/ledger/parameters/mod.rs
tzemanovic added a commit that referenced this pull request Nov 17, 2022
* bat/native-vp-test-tooling:
  Update tests/src/vm_host_env/tx.rs
  [feat]: Add multitoken suppor to the TestTxEnv. Add ability to execute wasm blobs on a TestTxEnv in order to test them with native vps
juped added a commit that referenced this pull request Nov 30, 2022
… into main

* namada/bat/native-vp-test-tooling:
  Update tests/src/vm_host_env/tx.rs
  [feat]: Add multitoken suppor to the TestTxEnv. Add ability to execute wasm blobs on a TestTxEnv in order to test them with native vps
@juped juped merged commit 97a5877 into main Nov 30, 2022
@juped juped deleted the tomas/implicit-vps branch November 30, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implicit account VP
2 participants