Removed MerkleValue type #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this is a thorn in my side I would be happy to remove |
juped
reviewed
Nov 30, 2022
shared/src/ledger/storage/mod.rs
Outdated
| @@ -625,7 +625,7 @@ where | |||
| pub fn get_existence_proof( | |||
| &self, | |||
| key: &Key, | |||
| value: MerkleValue, | |||
| value: Vec<u8>, | |||
|
i think test-wasm was broken by me, ignore for now |
tzemanovic
previously approved these changes
Nov 30, 2022
|
pls update wasm |
tzemanovic
added a commit
that referenced
this pull request
Dec 5, 2022
- remove `MerkleValue` from storage/mod moved to core crate * bat/remove-merkle-values: [fix]: Changed Vec<u8> to &[u8] for getting merkle proofs [feat]: Removed MerkleValue type
Closed
tzemanovic
approved these changes
Dec 5, 2022
juped
added a commit
that referenced
this pull request
Dec 13, 2022
* bat/remove-merkle-values: changelog: add #846 [fix]: Changed Vec<u8> to &[u8] for getting merkle proofs [feat]: Removed MerkleValue type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design of the merkle tree is that each subtree should handle it's own particulars and the top level storage should be unaware of these details. The MerkleValue type violated this principal by requiring top level storage to correctly cast values to the right type which would then be checked by the sub-trees. This caused bugs and made strained the storage API. This PR removes this type.