Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scroll back to top button #59

Merged
merged 10 commits into from Oct 6, 2022
Merged

Added scroll back to top button #59

merged 10 commits into from Oct 6, 2022

Conversation

zugzwang03
Copy link
Contributor

@zugzwang03 zugzwang03 commented Oct 4, 2022

Description

I added a scroll back to top button to scroll back to the landing page immediately on click.
An extra dependency added is react-icons, for the uparrow material icon.
Formatting has been changed in the process in some files as I was using a formatter in my code editor.

Fixes #37

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@Sneakad Sneakad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please maintain the indentation in the headers and keep it in one line.

Copy link
Collaborator

@Sneakad Sneakad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to create a separate page/ component for the scroll-up button. You just need to create a sticky button at the bottom-right corner of the Landing.jsx page. Add an event listener to that button which when clicked will scroll up to the hero section.

@Sneakad Sneakad self-requested a review October 4, 2022 08:05
@zugzwang03
Copy link
Contributor Author

is it fine now? @Sneakad

@zugzwang03
Copy link
Contributor Author

@Sneakad @anomic30

@Sneakad
Copy link
Collaborator

Sneakad commented Oct 6, 2022

@zugzwang03 the scroll back to the top button is not appearing on the landing page. Can you show your UI?

@zugzwang03
Copy link
Contributor Author

While I am trying to run your code in my local machine, the website is not working, it is asking for some magic API key, and I can't get it. I kind of guess worked, that the scroll button will work like this if I put on that code. I have no knowledge of API s yet :(

@anomic30
Copy link
Owner

anomic30 commented Oct 6, 2022

@zugzwang03, you can get the API keys by reading the client/readme.md file.

@zugzwang03
Copy link
Contributor Author

@zugzwang03, you can get the API keys by reading the client/readme.md file.

okayy

@zugzwang03
Copy link
Contributor Author

yupp, done.
It was a z-index problem actually
scrolltop

@zugzwang03
Copy link
Contributor Author

Also, will I add some box-shadow of #00FFA8 color?

@zugzwang03
Copy link
Contributor Author

@anomic30 @Sneakad

Copy link
Owner

@anomic30 anomic30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
LGTM.

@anomic30 anomic30 added enhancement New feature or request hacktoberfest labels Oct 6, 2022
@anomic30 anomic30 merged commit e2988ac into anomic30:main Oct 6, 2022
@anomic30 anomic30 added the hacktoberfest-accepted Accepted for Hacktoberfest 2022 label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted Accepted for Hacktoberfest 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create scroll back to top button
3 participants