New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added scroll back to top button #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please maintain the indentation in the headers and keep it in one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to create a separate page/ component for the scroll-up button. You just need to create a sticky button at the bottom-right corner of the Landing.jsx page. Add an event listener to that button which when clicked will scroll up to the hero section.
is it fine now? @Sneakad |
@zugzwang03 the scroll back to the top button is not appearing on the landing page. Can you show your UI? |
While I am trying to run your code in my local machine, the website is not working, it is asking for some magic API key, and I can't get it. I kind of guess worked, that the scroll button will work like this if I put on that code. I have no knowledge of API s yet :( |
@zugzwang03, you can get the API keys by reading the client/readme.md file. |
okayy |
Also, will I add some box-shadow of #00FFA8 color? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
LGTM.
Description
I added a scroll back to top button to scroll back to the landing page immediately on click.
An extra dependency added is react-icons, for the uparrow material icon.
Formatting has been changed in the process in some files as I was using a formatter in my code editor.
Fixes #37
Type of change
Checklist: