Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add local time #72

Merged
merged 2 commits into from Oct 6, 2022
Merged

add local time #72

merged 2 commits into from Oct 6, 2022

Conversation

spykelionel
Copy link
Contributor

@spykelionel spykelionel commented Oct 6, 2022

Description

Adds a local time to the uploaded file
Fixes #33

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@anomic30
Copy link
Owner

anomic30 commented Oct 6, 2022

Hi @spykelionel, the formatDates() function is being currently used in the MyFiles component which is a table to show list of uploaded files, and also in the FileDesc component. We want to show the time only in the FileDesc component. So can you make the necessary changes?

@anomic30 anomic30 self-requested a review October 6, 2022 13:07
: long date on file-desc
@spykelionel
Copy link
Contributor Author

Hi @spykelionel, the formatDates() function is being currently used in the MyFiles component which is a table to show list of uploaded files, and also in the FileDesc component. We want to show the time only in the FileDesc component. So can you make the necessary changes?

Alright!

Copy link
Owner

@anomic30 anomic30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😃!

@anomic30 anomic30 added enhancement New feature or request hacktoberfest-accepted Accepted for Hacktoberfest 2022 hacktoberfest labels Oct 6, 2022
@anomic30 anomic30 merged commit 1505647 into anomic30:main Oct 6, 2022
@spykelionel spykelionel deleted the local-time branch October 6, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted Accepted for Hacktoberfest 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File details Doesn't include the time
2 participants