Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addy.io 1.0.8 #260

Merged
merged 1 commit into from
Feb 18, 2024
Merged

addy.io 1.0.8 #260

merged 1 commit into from
Feb 18, 2024

Conversation

willbrowningme
Copy link
Member

No description provided.

@crazy-max
Copy link
Member

crazy-max commented Feb 18, 2024

Build on arm doesn't look good 😞: https://github.com/anonaddy/docker/actions/runs/7948027904/job/21697548411?pr=260#step:7:4324

#42 [linux/arm/v7 stage-1 5/6] RUN apk --no-cache add -t build-dependencies     git     nodejs     npm   && node --version   && npm --version   && addgroup -g 1000 anonaddy   && adduser -D -h /var/www/anonaddy -u 1000 -G anonaddy -s /bin/sh -D anonaddy   && addgroup anonaddy mail   && curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/bin --filename=composer   && git config --global --add safe.directory /var/www/anonaddy   && git init . && git remote add origin "https://github.com/anonaddy/anonaddy.git"   && git fetch --depth 1 origin "v1.0.7" && git checkout -q FETCH_HEAD   && composer install --optimize-autoloader --no-dev --no-interaction --no-ansi --ignore-platform-req=php-64bit   && chown -R anonaddy. /var/www/anonaddy   && npm ci --ignore-scripts   && APP_URL=https://addy-sh.test/ npm run production   && npm prune --production   && chown -R nobody.nogroup /var/www/anonaddy   && apk del build-dependencies   && rm -rf /root/.composer     /root/.config     /root/.npm     /var/www/anonaddy/.git     /var/www/anonaddy/node_modules     /tmp/*
#42 216.6 /var/www/anonaddy/node_modules/rollup/dist/native.js:38
#42 216.6 	throw new Error(
#42 216.6 	      ^
#42 216.6 
#42 216.6 Error: Your current platform "linux" and architecture "arm" combination is not yet supported by the native Rollup build. Please use the WASM build "@rollup/wasm-node" instead.
#42 216.6 
#42 216.6 The following platform-architecture combinations are supported:
#42 216.6 android-arm
#42 216.6 android-arm64
#42 216.6 darwin-arm64
#42 216.6 darwin-x64
#42 216.6 linux-arm
#42 216.6 linux-arm64
#42 216.6 linux-arm64 (musl)
#42 216.6 linux-riscv64
#42 216.6 linux-x64
#42 216.6 linux-x64 (musl)
#42 216.6 win32-arm64
#42 216.6 win32-ia32
#42 216.6 win32-x64
#42 216.6 
#42 216.6 If this is important to you, please consider supporting Rollup to make a native build for your platform and architecture available.
#42 216.6     at Object.<anonymous> (/var/www/anonaddy/node_modules/rollup/dist/native.js:38:8)
#42 216.6     at Module._compile (node:internal/modules/cjs/loader:1356:14)
#42 216.6     at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
#42 216.6     at Module.load (node:internal/modules/cjs/loader:1197:32)
#42 216.6     at Module._load (node:internal/modules/cjs/loader:1013:12)
#42 216.6     at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:202:29)
#42 216.6     at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
#42 216.6     at async ModuleLoader.import (node:internal/modules/esm/loader:336:24)

It says linux arm is not supported but then it's clearly specified in the supported platforms 🤷‍♂️

@willbrowningme
Copy link
Member Author

Hmm, that's strange. Do you think that's why the anonaddybot on https://hub.docker.com/repository/docker/anonaddy/anonaddy/general hasn't built the last tag v1.0.5?

@crazy-max
Copy link
Member

crazy-max commented Feb 18, 2024

Hmm, that's strange. Do you think that's why the anonaddybot on https://hub.docker.com/repository/docker/anonaddy/anonaddy/general hasn't built the last tag v1.0.5?

This is not related but I forgot to push the tag my bad, here you go: https://github.com/anonaddy/docker/releases/tag/1.0.5-r0

@willbrowningme
Copy link
Member Author

Hmm, that's strange. Do you think that's why the anonaddybot on https://hub.docker.com/repository/docker/anonaddy/anonaddy/general hasn't built the last tag v1.0.5?

This is not related but I forgot to push the tag my bad, here you go: https://github.com/anonaddy/docker/releases/tag/1.0.5-r0

Ah yes, I forgot about that too!

@crazy-max
Copy link
Member

@crazy-max
Copy link
Member

It says linux arm is not supported but then it's clearly specified in the supported platforms 🤷‍♂️

Ah actually linux-arm is supported but not with musl (alpine) 😞

@crazy-max
Copy link
Member

crazy-max commented Feb 18, 2024

@willbrowningme Seems rollup/rollup#5194 (comment) would solve the issue. In your case with vite: rollup/rollup#5194 (comment)

@willbrowningme
Copy link
Member Author

@crazy-max great find! I've just updated package.json, do I need to tag a new release to trigger a build?

Dockerfile Outdated Show resolved Hide resolved
@willbrowningme
Copy link
Member Author

Shall I close this PR?

Co-authored-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title addy.io 1.0.7 addy.io 1.0.8 Feb 18, 2024
@crazy-max
Copy link
Member

Shall I close this PR?

not needed, updated your changes to 1.0.8, let's see how it goes 👀

@crazy-max crazy-max merged commit f4dc6e2 into master Feb 18, 2024
2 checks passed
@crazy-max crazy-max deleted the update branch February 18, 2024 17:14
@willbrowningme
Copy link
Member Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants