src: remove kEagerCompile for CompileFunction

It wasn't doing anything, and actually enabling it would cause some tests to fail. Refs: nodejs#48576 PR-URL: nodejs#48671 Refs: v8/v8@cb00db4 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
anonrig · Jul 10, 2023 · 08459f5 · 08459f5
1 parent f27d670
commit 08459f5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/node_builtins.cc b/src/node_builtins.cc
@@ -285,7 +285,7 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
   const bool has_cache = cached_data.data != nullptr;
   ScriptCompiler::CompileOptions options =
       has_cache ? ScriptCompiler::kConsumeCodeCache
-                : ScriptCompiler::kEagerCompile;
+                : ScriptCompiler::kNoCompileOptions;
   ScriptCompiler::Source script_source(
       source,
       origin,

diff --git a/src/node_snapshotable.cc b/src/node_snapshotable.cc
@@ -1270,7 +1270,7 @@ void CompileSerializeMain(const FunctionCallbackInfo<Value>& args) {
                                       parameters.data(),
                                       0,
                                       nullptr,
-                                      ScriptCompiler::kEagerCompile)
+                                      ScriptCompiler::kNoCompileOptions)
           .ToLocal(&fn)) {
     args.GetReturnValue().Set(fn);
   }