Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run command improvements #7

Closed
4 tasks done
anonrig opened this issue Jul 14, 2023 · 9 comments
Closed
4 tasks done

Run command improvements #7

anonrig opened this issue Jul 14, 2023 · 9 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@anonrig
Copy link
Member

anonrig commented Jul 14, 2023

@anonrig anonrig added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 14, 2023
@vramana
Copy link
Contributor

vramana commented Jul 15, 2023

Should respect to ^ version pins while installing dependencies. For example, ajv@8.11.0 and ajv@8.12.0 should not be installed if both of them has the ^ version pin.

@anonrig I want to work on this

@anonrig
Copy link
Member Author

anonrig commented Jul 15, 2023

Should respect to ^ version pins while installing dependencies. For example, ajv@8.11.0 and ajv@8.12.0 should not be installed if both of them has the ^ version pin.

@anonrig I want to work on this

Perfect. Feel free to open a pull request. Happy to help if you get stuck on something!

@vramana
Copy link
Contributor

vramana commented Jul 15, 2023

@anonrig It seems writing a Resolver struct seems like the best way to me. Also I am planning to use https://crates.io/crates/node-semver

@anonrig
Copy link
Member Author

anonrig commented Jul 15, 2023

@anonrig It seems writing a Resolver struct seems like the best way to me. Also I am planning to use https://crates.io/crates/node-semver

There is also http://crates.io/crates/semver which is more widely used.

@vramana
Copy link
Contributor

vramana commented Jul 15, 2023

@anonrig In the past I read that, there are some differences between semver and node-semver but I don't have a clue that what the differences are.

This crate is a pure Rust-based implementation of JavaScript's node-semver. That is, it's designed to be compatible with Node/NPM's particular flavor of semver (which the semver crate is not).

From the readme is of node-semver

@anonrig
Copy link
Member Author

anonrig commented Jul 16, 2023

hey @vramana, did you had any chance to look into this? can you open a PR?

@vramana
Copy link
Contributor

vramana commented Jul 17, 2023

@anonrig I was working on it. But I could not work on it due to some prior commitment. I work on the last item. 👍🏽

@vramana
Copy link
Contributor

vramana commented Jul 19, 2023

@anonrig I think this can be closed now.

@anonrig
Copy link
Member Author

anonrig commented Jul 19, 2023

Agree. Thanks for the contribution! @vramana

@anonrig anonrig closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants