websocket: use Buffer.allocUnsafe (nodejs#1817)

anonrig · Apr 4, 2023 · 8af58e0 · 8af58e0
1 parent 7338154
commit 8af58e0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/websocket/frame.js b/lib/websocket/frame.js
@@ -27,9 +27,10 @@ class WebsocketFrameSend {
       payloadLength = 126
     }
 
-    // TODO: switch to Buffer.allocUnsafe
-    const buffer = Buffer.alloc(bodyLength + offset)
+    const buffer = Buffer.allocUnsafe(bodyLength + offset)
 
+    // Clear first 2 bytes, everything else is overwritten
+    buffer[0] = buffer[1] = 0
     buffer[0] |= 0x80 // FIN
     buffer[0] = (buffer[0] & 0xF0) + opcode // opcode
 

diff --git a/lib/websocket/receiver.js b/lib/websocket/receiver.js
@@ -198,6 +198,7 @@ class ByteParser extends Writable {
       const buffer = this.consume(8)
 
       // TODO: optimize this
+      // TODO: this likely doesn't work because it returns a bigint
       this.#info.payloadLength = buffer.readBigUint64BE(0)
       this.#state = parserStates.READ_DATA
     } else if (this.#state === parserStates.READ_DATA) {