fix: ensure header value is a string (nodejs#1899)

* fix: ensure header value is a string * fixup * fixup * fixup * fixup
anonrig · Apr 4, 2023 · f82c61d · f82c61d
1 parent d78fd2d
commit f82c61d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/core/request.js b/lib/core/request.js
@@ -279,9 +279,13 @@ class Request {
 }
 
 function processHeaderValue (key, val) {
-  if (val && (typeof val === 'object' && !Array.isArray(val))) {
+  if (val && typeof val === 'object') {
     throw new InvalidArgumentError(`invalid ${key} header`)
-  } else if (headerCharRegex.exec(val) !== null) {
+  }
+
+  val = val != null ? `${val}` : ''
+
+  if (headerCharRegex.exec(val) !== null) {
     throw new InvalidArgumentError(`invalid ${key} header`)
   }
 

diff --git a/test/client-dispatch.js b/test/client-dispatch.js
@@ -94,7 +94,7 @@ test('basic dispatch get', (t) => {
     t.equal(`localhost:${server.address().port}`, req.headers.host)
     t.equal(undefined, req.headers.foo)
     t.equal('bar', req.headers.bar)
-    t.equal('null', req.headers.baz)
+    t.equal('', req.headers.baz)
     t.equal(undefined, req.headers['content-length'])
     res.end('hello')
   })