Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider publishing the individual files to npm #3

Closed
devinus opened this issue Oct 3, 2019 · 2 comments
Closed

Consider publishing the individual files to npm #3

devinus opened this issue Oct 3, 2019 · 2 comments

Comments

@devinus
Copy link

devinus commented Oct 3, 2019

This would make tree-shaking in Webpack not include the same amalgamated file twice when used in ProvidePlugin.

@anonyco
Copy link
Owner

anonyco commented Oct 5, 2019

Thank you so much for opening this pressing issue. I'm sorry, but I am not certain about what you are referring to when you say "individual." Are you referring to the individual folder or a specific series of files? Also, if the latter, then which files?

Again, I really appreciate it when someone takes the time to identify a bug, track it down, and open an Issue to shed light upon it. Thank you.

@anonyco
Copy link
Owner

anonyco commented Oct 10, 2019

Success (I think)! I have pushed up a new version of the library to integrate an ES6 module alternative to the library because it appears as though ES6 modules are easier for webpack to swallow (please don't quote me on this--I just learned webpack today, so I do not know much about webpack).

Below is a download link for a "poor-man's" test used to validate whether or not the library is compatible with webpack. After opening the console on the demo.html page and refreshing, the number 15 appeared in the console and no errors were reported. Thus, I assume that my changes have fixed the issues with webpack. I realize that this is not a very good benchmark, but I am at a loss to find any better way to test this library's compatibility with webpack.

As I am still very new and inexperienced with ES6 modules and webpack, I would really appreciate your inspection and critique of my work in order to verify that everything has been done correctly with best-practices and so forth. Thank you so much for bringing this issue to my attention and explaining the problem so clearly and concisely. I really appreciate that you have spent your time to contribute to this project.

~ Happy coding!


Download my "poor-man's" webpack test

@anonyco anonyco closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants