Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TripReport model to be part of Trip model (#111) #190

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

anorthall
Copy link
Owner

Refactor the TripReport model to completely remove it and integrate it into the existing Trip model to reduce code duplication and simplify views and templates.

All existing TripReports will be migrated to the relevant field in a Trip and privacy will be adjusted to the most conservative option if the TripReport privacy differs from that of the Trip it migrates to.

@anorthall anorthall added front-end Templates and user experience back-end Views, business logic and models refactor Refactoring of existing code labels Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
app/core/logging.py 93.33% <100.00%> (+4.76%) ⬆️
app/logger/admin.py 97.61% <100.00%> (+0.95%) ⬆️
app/logger/factories.py 100.00% <100.00%> (+4.46%) ⬆️
app/logger/forms.py 100.00% <100.00%> (ø)
app/logger/mixins.py 84.31% <100.00%> (-4.58%) ⬇️
app/logger/models/__init__.py 100.00% <ø> (ø)
app/logger/models/trip.py 99.06% <100.00%> (-0.01%) ⬇️
app/logger/urls.py 100.00% <ø> (ø)
app/logger/views/__init__.py 100.00% <ø> (ø)
app/logger/views/userprofile.py 94.87% <ø> (ø)
... and 3 more

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@anorthall anorthall merged commit 7268678 into main Oct 20, 2023
3 checks passed
@anorthall anorthall deleted the trip-report-refactor branch October 25, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Views, business logic and models front-end Templates and user experience refactor Refactoring of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant