FIX: use git tag / git push instead of http soft tags #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This would be a lot nicer! I think it needs pretty good testing though given it's quite a fundamental change. Any ideas on how we could get confidence in testing it? |
|
Ill test this in a few repos in the next few weeks from my fork and confirm. |
|
@sammcj lets merge this hahaha everytime we merge a pr there are problems... look https://github.com/anothrNick/github-tag-action/actions/runs/5248300455/jobs/9479783919 from #272 tests succeded but permissions still dramatic I have no idea whats going on. I assume has to be related to ownership of source branch/repo |
commit code changes make it a flag so is not a breaking change add testing for patch fix id
sammcj
approved these changes
Jun 13, 2023
This was referenced Jun 13, 2023
This was referenced Apr 15, 2024
1 task
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change git tag over http to git cli
Fixes: https://github.com/anothrNick/github-tag-action/actions/runs/3372412451/jobs/5595804270#step:4:89
My availability to test this is low.
But is what we use to tag the major tag in here https://github.com/anothrNick/github-tag-action/blob/master/.github/workflows/main.yml#L36-L50
I don't see why not use the same approach everywhere instead of soft tags.
We might need to add more checks to this.