Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of releases in the output map #76

Merged
merged 2 commits into from Aug 8, 2018
Merged

Conversation

ansasaki
Copy link
Owner

@ansasaki ansasaki commented Aug 8, 2018

This order the releases in reverse order, with older versions first.
The tests were fixed accordingly.

fixes #75

The linker expects the dependencies to be declared before used in the
symbol version script.  This fixes the bug and updates all the affected
test data.
@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files           4        4           
  Lines         740      740           
  Branches      190      190           
=======================================
  Hits          722      722           
  Partials       18       18
Impacted Files Coverage Δ
src/abimap/symver.py 97.52% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f376d8c...8c1914e. Read the comment docs.

@ansasaki ansasaki merged commit 004ac8a into master Aug 8, 2018
@ansasaki ansasaki deleted the fix_sort_nice_bug branch August 8, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The order of releases in the output map is wrong
2 participants