-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostgreSQL use: compilation failure #15
Comments
pallavisontakke writes:
This was due to error in https://github.com/anse1/sqlsmith/blob/master/Makefile.am at line 26.
Here POSTGRESQL_CFLAGS is erroneously mentioned as POSTGRESQL_CPPFLAGS .
Replacing it fixes this issue
I don't think this can be the explanation: The autoconf macro I use does
not substitute the former at all according to its documentation. See
https://www.gnu.org/software/autoconf-archive/ax_lib_postgresql.html
Having the right pg_config in $PATH, POSTGRESQL_CPPFLAGS substitutes the
proper include path for my 10.1 build. Maybe ./configure picked up the
wrong pg_config binary on your system? You can force a specific one
using
./configure --with-postgresql=/path/to/bin/pg_config
regards,
Andreas
|
What I meant was, in sqlsmith code , I see POSTGRESQL_CFLAGS being set to 'includedir' values, so it can get header files.
However, POSTGRESQL_CPPFLAGS is only being used, but not being set anywhere:
Also, PG_CONFIG is set properly in my environment during build:
And configure is picking it up properly as well:
|
pallavisontakke writes:
***@***.***:~/sources/sqlsmith$ grep -rn 'POSTGRESQL_CFLAGS' *|more
aclocal.m4:559:# AC_SUBST(POSTGRESQL_CFLAGS)
aclocal.m4:597: POSTGRESQL_CFLAGS=""
aclocal.m4:620: POSTGRESQL_CFLAGS="-I`$PG_CONFIG --includedir`"
aclocal.m4:682: AC_SUBST([POSTGRESQL_CFLAGS])
I see now: You are using an old version of autoconf-archive that comes
with a AX_LIB_POSTGRESQL that substitutes POSTGRESQL_CFLAGS instead of
POSTGRESQL_CPPFLAGS:
,----[ git://git.sv.gnu.org/autoconf-archive.git ]
| commit f6c5e7ac8c50fe2ad35aae176f518eb95f66c588
| Author: Sree Harsha Totakura <sreeharsha@totakura.in>
| Date: Wed Oct 15 11:12:25 2014 +0200
|
| AX_LIB_POSTGRESQL: substitute CPPFLAGS rather than CFLAGS
|
`----
If you run autoreconf with the current version of autoconf-archive, the
Makefile should work as intended without changes.
|
ok, fine , in that case it's ok to close this Issue. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hi @anse1
When trying to use sqlsmith for PostgreSQL 11, I was facing this compilation issue:
This was due to error in https://github.com/anse1/sqlsmith/blob/master/Makefile.am at line 26.
Here POSTGRESQL_CFLAGS is erroneously mentioned as POSTGRESQL_CPPFLAGS .
Replacing it fixes this issue
The text was updated successfully, but these errors were encountered: