Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup.html: add extra saccades styling options under saccades color #129 #131

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

rezwan-hossain
Copy link
Contributor

  • add extra options in saccades color. The extra options will be saccades-solid-line, saccades-dash-line, saccades-dotted-line, saccades-strickthrough-line
  • give the options the same value as the text it shows
  • change saccades color label to saccades style

@asieduernest12
Copy link
Collaborator

thanks @rezwan-hossain you completed task 1 and task 2 correctly.
Originally, I was expecting the new option additions to be added as part of Saccade colors which means they would have served as extra saccades color alternatives
The final task was to change the Saccades color label to say saccades styles to reflect new new purpose.

Fortunately by you missing to complete task 3. I have realized it is better to keep the Saccades color while providing the saccades styles as a different feature.

Very nice work.

@asieduernest12 asieduernest12 merged commit a160715 into ansh:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants