Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email API integration #282

Closed
wants to merge 8 commits into from
Closed

Email API integration #282

wants to merge 8 commits into from

Conversation

Serienmorder
Copy link
Contributor

Supports the email API of nexus that is in 3.22.

@Serienmorder
Copy link
Contributor Author

@zeitounator I think a new var needs be put into use for the API interaction? Or is there something already there that I'm missing? Needs to have the IP and a port number if applicable..

@Serienmorder
Copy link
Contributor Author

I'm thinking of doing it in this style as a "first wave" and then wrapping them all around with action plugins. What do you think of that. Get moving forward on API integration. Get more generic as things continue.

@Serienmorder Serienmorder mentioned this pull request Apr 17, 2020
Open
@zeitounator zeitounator self-requested a review April 17, 2020 21:01
@zeitounator zeitounator self-assigned this Apr 17, 2020
@zeitounator
Copy link
Member

Hi. I need to review this and take some decisions. I will have time for that next week probably. At first glance, I'm not really sure about the specific module, and I'm not really comfortable with tests vars and files being added to the role itself when they should be in molecule only. But I really need to read that other than quickly and tired at 11pm my time after a particularly hard week of work... Thanks, keep you updated.

@Serienmorder
Copy link
Contributor Author

Serienmorder commented Apr 20, 2020 •
edited

Yup I get that. I'm willing to change whatever you need. The nice thing about the tests is that it can show other ways the module can be used? One of the reasons I opened the PR was for you to see what I've been working on and to confirm I should still continue going that way forward.

This may also be a good reason for switching to a collection? Have the install in one role of the collection, and the email stuff in a different role?

@Serienmorder Serienmorder marked this pull request as draft April 28, 2020 20:06
@Serienmorder
Cleanup for linter
80fed3c 
tidy'd things up for linter
Ran ansible lint locally.
Swap to var that should handle correctly.


Fix URL due to finding example of pre-composed list.


Crank up verbosity


Changed when statement.


Revert "Crank up verbosity"

This reverts commit 6bcfa91.
@Serienmorder Serienmorder marked this pull request as ready for review April 28, 2020 20:51
@Serienmorder
Copy link
Contributor Author

Fixed the issues. Except whatever set -e does. I can't seem to find anything about it with ansible-lint, or molecule. So I'm at a loss why that is failing.

@zeitounator zeitounator added the on hold Changes / decision / precisions / time needed label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeitounator zeitounator Awaiting requested review from zeitounator

Assignees

@zeitounator zeitounator

Labels
on hold Changes / decision / precisions / time needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Serienmorder @zeitounator