Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance/lint with recent rules #363

Conversation

zeitounator
Copy link
Member

@zeitounator zeitounator commented Dec 9, 2022

Update role to latest best practices and starndardize code:

  • Re-enable ansible-lint as dependency and a linter in molecule
  • Remove version constraint on molecule as schema validation is fixed in 4.0.3
  • ignore possible venvs for linting
  • Fix all errors/warning reported by ansible lint
    • jinja spacing
    • schema in meta/main.yaml
    • tasks/playbooks names related warnings / errors
    • file permissions not set in modules
    • name/when/block key order
    • FQCNs for every module
  • Disable molecule dependency manager as we have no deps
  • Added pre-commit configuration and configured some plugins. Let them do their job
    • Black now reformats python code
    • new line at end automatically added
    • trailing spaces automatically removed
  • Use python f-strings wherever possible

@zeitounator zeitounator self-assigned this Dec 9, 2022
@zeitounator zeitounator added the maintenance Related to support of new version of nexus, ansible... label Dec 9, 2022
@zeitounator zeitounator merged commit f836c34 into ansible-ThoTeam:main Dec 9, 2022
@zeitounator zeitounator deleted the maintenance/lint_with_recent_rules branch December 9, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Related to support of new version of nexus, ansible...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant