Feature: Add retries to download #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is of excellent quality ! This is already on main (going through CI) and will be included in the next tagged release (with citations in the notes). Thanks for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a retry to the download of the Nexus package.
We currently use this role to install Nexus. However, we also use an existing Nexus which serves as a proxy for the Nexus packages. When downloading a newer version that is not yet available, the installation can fail because of a timeout when the new artifact is still downloading (with a slower internet connection, this is a common issue we have). Adding a retry is a solution for this issue.
Current behavior isn't changed because of the introduction of two new variables (which are also documented in the readme)