Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change layoutPolicy to deployPolicy for Yum repository closes #380 #392

Merged
merged 6 commits into from
Dec 16, 2023

Conversation

brianveltman
Copy link
Contributor

Update create_repos_from_list.groovy

change layoutPolicy to deployPolicy
@brianveltman
Copy link
Contributor Author

fixes #380

@zeitounator zeitounator closed this Dec 8, 2023
@zeitounator zeitounator reopened this Dec 8, 2023
@zeitounator zeitounator self-requested a review December 13, 2023 02:45
@zeitounator zeitounator self-assigned this Dec 13, 2023
Copy link
Member

@zeitounator zeitounator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is apparently not meeting the target. See the errors in CI. Extract:

        {
            "error_msg": "javax.validation.ConstraintViolationException: attributes[maven].layoutPolicy: must not be null",
            "format": "maven2",
            "name": "central",
            "status": "error",
            "type": "proxy"
        },
        {
            "error_msg": "javax.validation.ConstraintViolationException: attributes[maven].layoutPolicy: must not be null",
            "format": "maven2",
            "name": "jboss",
            "status": "error",
            "type": "proxy"
        },
        {
            "error_msg": "javax.validation.ConstraintViolationException: attributes[maven].layoutPolicy: must not be null",
            "format": "maven2",
            "name": "private-release",
            "status": "error",
            "type": "hosted"
        },

@brianveltman
Copy link
Contributor Author

I will fix this and push the changes later today :-)

Working with immutable artifacts is a CICD best practise, therefore the default deploy policy is set to strict. Strict is the Nexus default as well
@brianveltman
Copy link
Contributor Author

brianveltman commented Dec 13, 2023

Ah I see, inconsistency on the Nexus part. For yum its called deployPolicy. For maven its called layoutPolicy.
@zeitounator What do you think, should we introduce a new ansible variable for this or not?

Technically its a different attribute. But when you take a look at the Nexus UI, its called Layout Policy for both repo types.

@brianveltman brianveltman changed the title change layoutPolicy to deployPolicy change layoutPolicy to deployPolicy for Yum repository Dec 13, 2023
Copy link
Member

@zeitounator zeitounator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good enough with a single var on nexus side since the UI uses the same name. We can always change that later if need be. Thanks for the fix.

@brianveltman brianveltman changed the title change layoutPolicy to deployPolicy for Yum repository change layoutPolicy to deployPolicy for Yum repository closes #380 Dec 15, 2023
@zeitounator zeitounator merged commit 16e0f03 into ansible-ThoTeam:main Dec 16, 2023
1 of 2 checks passed
@brianveltman brianveltman deleted the patch-1 branch December 17, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants